Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for ruby 1.9 #164

Closed
wants to merge 1 commit into from
Closed

Fix build for ruby 1.9 #164

wants to merge 1 commit into from

Conversation

maxjacobson
Copy link
Contributor

@maxjacobson maxjacobson commented Dec 27, 2016 •
edited
Loading

The newer webmock doesn't allow using with Ruby 1.9.3

@maxjacobson maxjacobson mentioned this pull request Dec 27, 2016
Merged
@maxjacobson
Copy link
Contributor Author

I'll just cherry-pick this commit onto #163

@maxjacobson maxjacobson deleted the mj/fix-1.9-build branch December 28, 2016 23:06
ABaldwinHunter
ABaldwinHunter reviewed Dec 28, 2016
View reviewed changes
Copy link
Contributor

@ABaldwinHunter ABaldwinHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABaldwinHunter ABaldwinHunter ABaldwinHunter left review comments

@chrishulton chrishulton Awaiting requested review from chrishulton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxjacobson @ABaldwinHunter